Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing TODO #957

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Addressing TODO #957

merged 2 commits into from
Oct 9, 2024

Conversation

Tang8330
Copy link
Contributor

@Tang8330 Tang8330 commented Oct 8, 2024 •
edited
Loading

Have ParseNumeric return typing.Invalid along with an error rather than just that the column is invalid, so we can be more explicit.

@Tang8330 Tang8330 changed the title Implementing TODO Addressing TODO Oct 8, 2024
@Tang8330 Tang8330 marked this pull request as ready for review October 8, 2024 23:18
@Tang8330 Tang8330 requested a review from a team as a code owner October 8, 2024 23:18
@Tang8330 Tang8330 merged commit ccfa3fd into master Oct 9, 2024
3 checks passed
@Tang8330 Tang8330 deleted the implement-todo branch October 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danafallon danafallon danafallon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tang8330 @danafallon